Homogenize const types with usage in action and type storage#87
Merged
Homogenize const types with usage in action and type storage#87
Conversation
Member
|
Was the alternative considered - to change the type of the |
Contributor
Author
|
That would be possible but would be changing the message format. Which would then require bag migrations and other mechanisms. Right now the consts are just being implicitly cast to the larger type when assigned into the message and consequently this is the least disruptive resolution. |
dirk-thomas
approved these changes
May 15, 2020
hidmic
approved these changes
May 18, 2020
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
1f24554 to
c241b99
Compare
Contributor
Author
|
Rebased with basic CI to test code changes Linux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to the Aggregate Foxy Message API Review
In both Marker and ImageMarker the constants are all uint8
common_interfaces/visualization_msgs/msg/ImageMarker.msg
Lines 1 to 8 in 519e851
However the action and type they are used in are int32
common_interfaces/visualization_msgs/msg/ImageMarker.msg
Lines 15 to 18 in 519e851
This proposes to homogenize them by changing the const's declared type to be consistent.