Conversation
Fixes #92 Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
hidmic
approved these changes
May 18, 2020
geometry_msgs/msg/Vector3Stamped.msg
Outdated
| @@ -1,4 +1,7 @@ | |||
| # This represents a Vector3 with reference coordinate frame and timestamp | |||
|
|
|||
| # Note that this follows vector semantics with it alwasy being at the origin, | |||
There was a problem hiding this comment.
Suggested change
| # Note that this follows vector semantics with it alwasy being at the origin, | |
| # Note that this follows vector semantics with it always anchored at the origin, |
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
jacobperron
reviewed
May 19, 2020
geometry_msgs/msg/Vector3.msg
Outdated
|
|
||
| # This is semantically different than a point. | ||
| # A vector is always anchored at the origin. | ||
| # When a trasform is applied to a vector only |
Member
There was a problem hiding this comment.
Suggested change
| # When a trasform is applied to a vector only | |
| # When a transform is applied to a vector only |
mjcarroll
approved these changes
May 19, 2020
Member
mjcarroll
left a comment
There was a problem hiding this comment.
LGTM with suggestions applied.
Only nit is that your wrapping is inconsistent between the two files (wrapping at comma in one and at fixed length at other?)
Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92