Use the correct interpreter for Windows Debug.#755
Merged
clalancette merged 1 commit intomasterfrom Oct 3, 2024
Merged
Conversation
This was referenced Feb 16, 2024
c2b0011 to
bbdf0e3
Compare
3825409 to
357e656
Compare
357e656 to
7926d43
Compare
7926d43 to
90b96b1
Compare
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
90b96b1 to
c28517d
Compare
ahcorde
approved these changes
Sep 26, 2024
cottsay
approved these changes
Sep 26, 2024
Member
cottsay
left a comment
There was a problem hiding this comment.
A couple of non-critical thoughts:
- I'm not blown away by the fact that we're coupling this code to a provisioning detail like the installation location of the python debug interpreter executable, but I don't see an obvious way to avoid it.
- Because it's just a simple substitution, you man consider using
str.replace()instead of a regex.
Contributor
Author
|
CI for this (along with all of the rest of the changes needed) is in ros2/ros2#1524 (comment) |
Contributor
Author
|
Thanks for the review. For now, I'm going to leave it as a regex just to get this in. I have some larger plans for revamping this whole file, so we can probably address that at that point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is connected with ros2/ros2#1524 ; before we merge in most of the PRs connected with that, we'll need to merge in something like this fix. Note that this is still a draft because I need to test deploy this.