Install LTTng and related packages on Linux by christophebedard · Pull Request #690 · ros2/ci

christophebedard · 2023-01-27T00:40:10Z

Signed-off-by: Christophe Bedard christophe.bedard@apex.ai

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>

christophebedard · 2023-03-24T00:57:02Z

linux_docker_resources/Dockerfile-RHEL

    python3-importlib-metadata \
    $(if test ${EL_RELEASE} = 8; then echo python3-importlib-resources; fi) \
    python3-lark-parser \
+    $(if test ${EL_RELEASE} != 8; then echo python3-lttng; fi) \


I think lttng-ust should work, but I'm not completely sure about python3-lttng.

However, looking at this, I think it should work: https://github.com/ros/rosdistro/blob/bbf74994da40a4905b25bd27fab44b22c5ec9b2c/rosdep/python.yaml#L7651

RHEL 8 has python3-lttng, but the problem is that it's too old and tracetools breaks if it's present. I removed it in #657. Until tracetools handles the old version gracefully (which I'd still very much like to see), this is the best workaround.

Old versions can definitely be handled better, but this only installs python3-lttng on RHEL 9.

clalancette

If we keep our view focused to Rolling, then these changes look good to me.

However, these Dockerfiles are also used for Humble (Ubuntu 22.04/RHEL-8) and Foxy (Ubuntu 20.04/RHEL-8). In both cases, we'll be adding packages that weren't there before. What is ros2_tracing going to do in those circumstances? I don't want to enable it in the stable distributions (particularly Foxy), for fear it might break something.

christophebedard · 2023-03-28T18:56:22Z

However, these Dockerfiles are also used for Humble (Ubuntu 22.04/RHEL-8) and Foxy (Ubuntu 20.04/RHEL-8). In both cases, we'll be adding packages that weren't there before. What is ros2_tracing going to do in those circumstances? I don't want to enable it in the stable distributions (particularly Foxy), for fear it might break something.

Oh, I missed that. That's indeed not great, because then tracetools would find LTTng and would include the tracepoints: https://github.com/ros2/ros2_tracing/blob/foxy/tracetools/CMakeLists.txt#L27.

I can do ${UBUNTU_DISTRO} = jammy and ${ROS_DISTRO} != humble for Ubuntu and ${EL_RELEASE} != 8 for RHEL for all these new packages.

clalancette · 2023-03-28T19:05:33Z

I can do ${UBUNTU_DISTRO} = jammy and ${ROS_DISTRO} != humble for Ubuntu and ${EL_RELEASE} != 8 for RHEL for all these new packages.

Yeah, that is probably a good idea. I'll also suggest putting this in a separate block in the Ubuntu Dockerfile, similar to

ci/linux_docker_resources/Dockerfile

Line 97 in 7cbb9f6

    
           RUN if test \( ${PLATFORM} = x86 -a ${INSTALL_CONNEXT_DEBS} = true -a ${UBUNTU_DISTRO} != jammy \); then apt-get update && RTI_NC_LICENSE_ACCEPTED=yes apt-get install -y rti-connext-dds-5.3.1; fi

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>

christophebedard · 2023-03-28T19:16:44Z

I'll also suggest putting this in a separate block in the Ubuntu Dockerfile

Done!

clalancette

This looks good to me, though I'll want to see Linux CI for all of Foxy, Humble, and Rolling on both Ubuntu and RHEL. I'd also like to get one more approval from @cottsay .

clalancette · 2023-03-28T19:42:10Z

This looks good to me, though I'll want to see Linux CI for all of Foxy, Humble, and Rolling on both Ubuntu and RHEL. I'd also like to get one more approval from @cottsay .

Oh, actually, I guess I need to run it, since we can only do tests on local branches (not forks). I'll wait to hear from Scott before kicking that off.

cottsay

One quick change

linux_docker_resources/Dockerfile-RHEL

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>

cottsay

Thanks!

clalancette · 2023-03-29T12:42:44Z

OK, I've pushed an exact copy of this branch to the origin. Here are some CI runs with that in place:

Foxy:

Linux
Linux-aarch64
RHEL-8

Humble:

Linux
Linux-aarch64
RHEL-8

Rolling:

Linux
Linux-aarch64
RHEL-9

christophebedard · 2023-03-29T16:02:18Z

I thought we didn't need lttng-tools (which provides the CLI), but I forgot that I added it as an <exec_depend> of tracetools and that we need it in tracetools_trace: https://github.com/ros2/ros2_tracing/blob/e664e5bbd28b42da6430623fc1bcf644d6b6a449/tracetools_trace/tracetools_trace/tools/lttng.py#L90-L94. I'll add it as an exec dependency of tracetools_trace in ros2/ros2_tracing#31 and add it here.

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>

christophebedard · 2023-03-29T16:21:44Z

I also noticed that there was no rosdep rule for lttng-tools for RHEL, so I added it: ros/rosdistro#36641

clalancette · 2023-03-29T17:28:45Z

All right. I'm only going to run the latest change against Rolling again, given that it is protected under the same checks as the previous code.

clalancette · 2023-03-29T17:32:08Z

Rolling:

Linux
Linux-aarch64
RHEL-9

christophebedard · 2023-03-29T21:12:19Z

The test failures on RHEL don't seem to be related, but I can't find the same failures in recent jobs.

clalancette · 2023-03-29T21:32:48Z

The test failures on RHEL don't seem to be related, but I can't find the same failures in recent jobs.

That one is a flaky test; you can see a failure of it in https://ci.ros2.org/view/nightly/job/nightly_linux-rhel_repeated/1448/#showFailuresLink . I really don't think it is involved here at all.

So I think we are good with this change.

Once we merge this in, that means that we'll be building tracepoints in by default for Rolling in our nightly CI jobs and our nightly packaging (tarball) jobs. What needs to happen to have it enabled in the debians? Do we just need to do a release of ros2_tracing for that to happen?

christophebedard · 2023-03-29T21:43:14Z

Once we merge this in, that means that we'll be building tracepoints in by default for Rolling in our nightly CI jobs and our nightly packaging (tarball) jobs. What needs to happen to have it enabled in the debians? Do we just need to do a release of ros2_tracing for that to happen?

Specifically after merging ros2/ros2_tracing#31 (which I think we should merge right after this), yes! LTTng will be picked up as a dependency (otherwise the build will fail), and the tracepoints will be compiled in.

Well, that's what I think will happen, anyway. I can check the testing repo and validate once it's re-built.

christophebedard · 2023-03-29T21:46:29Z

Next step before merging would be to run CI using this branch and ros2/ros2_tracing#31. See ros2/ros2_tracing#31 (comment)

clalancette · 2023-03-30T11:59:07Z

Next step before merging would be to run CI using this branch and ros2/ros2_tracing#31. See ros2/ros2_tracing#31 (comment)

Awesome, the jobs there look good.

So what is the next step here? Do you want to merge the ros2_tracing PR, then I can merge this one?

christophebedard · 2023-03-30T16:02:57Z

So what is the next step here? Do you want to merge the ros2_tracing PR, then I can merge this one?

Since packages will now depend on LTTng, and since CI doesn't seem to run rosdep install (except for RHEL, it seems), we should merge this first. Then I'll merge ros2/ros2_tracing#31 right after.

clalancette · 2023-03-30T18:50:43Z

Since packages will now depend on LTTng, and since CI doesn't seem to run rosdep install (except for RHEL, it seems), we should merge this first. Then I'll merge ros2/ros2_tracing#31 right after.

OK, got it.

So, the only thing is that I'm on PTO, not checking email, starting about now until Monday (April 3). Despite the fact that I think we've done sufficient testing here, I'm somewhat reluctant to merge something like this and disappear. So either we should have @cottsay merge it and keep an eye on it tomorrow, or I can do it first thing Monday morning when I'm back. @cottsay what do you think?

christophebedard · 2023-03-30T19:07:46Z

Waiting until Monday as a precaution is fine with me.

christophebedard mentioned this pull request Jan 27, 2023

Declare a dependency on the (Linux-only) LTTng userspace tracer ros2/ros2#1177

Closed

1 task

Install LTTng and related packages on Linux

d721c3c

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>

christophebedard force-pushed the christophebedard/install-lttng-on-linux branch from 6077844 to d721c3c Compare March 24, 2023 00:39

christophebedard marked this pull request as ready for review March 24, 2023 00:39

christophebedard requested review from clalancette, cottsay and nuclearsandwich as code owners March 24, 2023 00:39

Install LTTng and related packages on RHEL

c9936b7

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>

christophebedard commented Mar 24, 2023

View reviewed changes

clalancette reviewed Mar 28, 2023

View reviewed changes

Restrict to Jammy && Rolling/Iron and RHEL 9

4180f29

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>

clalancette approved these changes Mar 28, 2023

View reviewed changes

cottsay requested changes Mar 28, 2023

View reviewed changes

linux_docker_resources/Dockerfile-RHEL Outdated Show resolved Hide resolved

Install lttng-ust-devel on RHEL instead of lttng-ust

f1bfe3f

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>

cottsay approved these changes Mar 28, 2023

View reviewed changes

Add lttng-tools

0cc0ff2

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>

cottsay approved these changes Mar 29, 2023

View reviewed changes

christophebedard mentioned this pull request Mar 29, 2023

Include tracepoints by default on Linux ros2/ros2_tracing#31

Merged

clalancette merged commit 9b463ba into ros2:master Apr 3, 2023

christophebedard deleted the christophebedard/install-lttng-on-linux branch April 3, 2023 15:10

Conversation

christophebedard commented Jan 27, 2023

Uh oh!

christophebedard Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cottsay Mar 24, 2023

Choose a reason for hiding this comment

Uh oh!

christophebedard Mar 24, 2023

Choose a reason for hiding this comment

Uh oh!

clalancette left a comment

Choose a reason for hiding this comment

Uh oh!

christophebedard commented Mar 28, 2023

Uh oh!

clalancette commented Mar 28, 2023

Uh oh!

christophebedard commented Mar 28, 2023

Uh oh!

clalancette left a comment

Choose a reason for hiding this comment

Uh oh!

clalancette commented Mar 28, 2023

Uh oh!

cottsay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cottsay left a comment

Choose a reason for hiding this comment

Uh oh!

clalancette commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christophebedard commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christophebedard commented Mar 29, 2023

Uh oh!

clalancette commented Mar 29, 2023

Uh oh!

clalancette commented Mar 29, 2023

Uh oh!

christophebedard commented Mar 29, 2023

Uh oh!

clalancette commented Mar 29, 2023

Uh oh!

christophebedard commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christophebedard commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clalancette commented Mar 30, 2023

Uh oh!

christophebedard commented Mar 30, 2023

Uh oh!

clalancette commented Mar 30, 2023

Uh oh!

christophebedard commented Mar 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

christophebedard Mar 24, 2023 •

edited

Loading

clalancette commented Mar 29, 2023 •

edited

Loading

christophebedard commented Mar 29, 2023 •

edited

Loading

christophebedard commented Mar 29, 2023 •

edited

Loading

christophebedard commented Mar 29, 2023 •

edited

Loading