Conversation
The pydocstyle and lttng python packages recently became available in EPEL 8, so I re-ran the rosdep command to see if there were any other packages that we've been missing. Turns out there were a decent amount! Signed-off-by: Scott K Logan <logans@cottsay.net>
This dependency is missing. We should address that. Signed-off-by: Scott K Logan <logans@cottsay.net>
clalancette
reviewed
Apr 12, 2022
Contributor
clalancette
left a comment
There was a problem hiding this comment.
I've left one comment inline, this otherwise looks good to me.
| CUnit-devel \ | ||
| acl \ | ||
| assimp-devel \ | ||
| bison \ |
Contributor
There was a problem hiding this comment.
I'm fairly confident that bison is required to build CycloneDDS by default, though that dependency is not properly expressed in https://github.com/eclipse-cyclonedds/cyclonedds/blob/releases/0.9.x/package.xml . I'm surprised the build succeeded without that, maybe it got pulled in by something else?
Member
Author
There was a problem hiding this comment.
As of March, it is optional: eclipse-cyclonedds/cyclonedds#1155
Maybe it would be best to leave it in for Galactic, though. I'll revert it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pydocstyle and lttng python packages recently became available in EPEL 8, so I re-ran the rosdep command to see if there were any other packages that we've been missing. Turns out there were a decent amount!
Before:
After:
Analyzing the builds, we have the same number of CMake/gcc/clang warnings between them, which is expected.
The test failures go from 15 to 10, but it's a little more complex than that. This PR will actually fix the vast majority of the 15 test failures, but meeting the lttng dependency of tracetools means that 6 previously skipped tests are now running (and failing). I'll investigate those failures another time, which should be easier now that we can actually run the tests!