Conversation
This ensures git submodules are also checked out (e.g. the pybind11 submodule in orocos_kdl). Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
Adding this in general doesn't thrill me because recursive submodules aren't captured in |
That's a good point. I think we should make it so that it can. Right now, bloom is fetching submodules so I think it's reasonable to have that behavior here too. |
|
After an upstream patch to |
I don't think that's an unreasonable position. I would be happier removing submodule support from bloom than adding it here. Its addition in bloom was not intentional as much as it was enabled by features in vcstool and then unblocked to "make a thing work" but it's worth thinking about whether it's a supportable pattern. |
|
Given the last couple of comments, I'm going to close this out since I don't think we'll move forward here. Feel free to reopen if I'm wrong. |
This ensures git submodules are also checked out (e.g. the pybind11 submodule in orocos_kdl).
Related to ros2/ros2#1208