Skip to content

Add --recursive option to vcs import#599

Closed
jacobperron wants to merge 1 commit intomasterfrom
jacob/upstream_orocos_kdl
Closed

Add --recursive option to vcs import#599
jacobperron wants to merge 1 commit intomasterfrom
jacob/upstream_orocos_kdl

Conversation

@jacobperron
Copy link
Copy Markdown
Member

This ensures git submodules are also checked out (e.g. the pybind11 submodule in orocos_kdl).

Related to ros2/ros2#1208

This ensures git submodules are also checked out (e.g. the pybind11 submodule in orocos_kdl).

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@nuclearsandwich
Copy link
Copy Markdown
Member

Adding this in general doesn't thrill me because recursive submodules aren't captured in vcs export --exact. I know there's a specific case this is checking and that the PR is still in draft but I wanted to express apprehension before I forgot about it.

@cottsay
Copy link
Copy Markdown
Member

cottsay commented Feb 18, 2022

Adding this in general doesn't thrill me because recursive submodules aren't captured in vcs export --exact.

That's a good point. I think we should make it so that it can.

Right now, bloom is fetching submodules so I think it's reasonable to have that behavior here too.

@jacobperron
Copy link
Copy Markdown
Member Author

After an upstream patch to python_orocos_kdl, I don't think we need this feature any longer. I'll plan to close this PR unless there's consensus to move forward with it.

@nuclearsandwich
Copy link
Copy Markdown
Member

Right now, bloom is fetching submodules so I think it's reasonable to have that behavior here too.

I don't think that's an unreasonable position. I would be happier removing submodule support from bloom than adding it here.

Its addition in bloom was not intentional as much as it was enabled by features in vcstool and then unblocked to "make a thing work" but it's worth thinking about whether it's a supportable pattern.

@clalancette
Copy link
Copy Markdown
Contributor

Given the last couple of comments, I'm going to close this out since I don't think we'll move forward here. Feel free to reopen if I'm wrong.

@jacobperron jacobperron deleted the jacob/upstream_orocos_kdl branch March 28, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants