Patch pytest.ini files present in ROS packages to include xunit2 format#406
Merged
Patch pytest.ini files present in ROS packages to include xunit2 format#406
Conversation
dirk-thomas
reviewed
Mar 11, 2020
Author
|
I changed the manipulation of the |
dirk-thomas
reviewed
Mar 11, 2020
Member
dirk-thomas
left a comment
There was a problem hiding this comment.
With pytest version 6 this setting is only necessary of it is explicitly configured to the legacy value (see https://docs.pytest.org/en/latest/changelog.html#pytest-5-3-0-2019-11-19). This can be implemented in a follow up PR to not block merging this fix.
Author
|
new changes tested here |
dirk-thomas
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to xunit 2.x Jenkins plugin is not working in situations where ROS packages ship their own pytest.ini file (i.e. ament_package) since it takes precedence over the
pytest.inicreated in the scripts.I've tested the changes in this build. Note that failures are coming from cppcheck (which is a different bug) not about pytest.xml.
Alternatively (or in addition) another way of fixing Jenkins would be to include the
junit_familydirective in the pytest.ini file of each ROS package that has this file in it: ament_package, ament_pyflakes, launch_testing_ros, launch_testing.