Add tinyxml and Eigen3 as dependencies#34
Conversation
|
Should this wait for #32 and be added to the "only install the dependencies if appropriate" part ? |
|
Is there a reason not to use TinyXML2 ( |
|
That would require a change in URDFdom / URDFdom_headers / orocos_kdl / robot_model. For now, we only have minor changes to these packages. |
|
I am not sure if both versions can be used at the same time which would be necessary as soon as we update to the latest FastRTPS version again (if they are exposed transitively through the headers). |
|
TinyXML and TinyXML2 are completely separate. They can be used at the same time. We already have this case in ROS 1, where urdf uses tinyxml(1) and other stuff uses tinyxml2. On my machine, both are installed: I believe it is the same on Linux. |
|
So it compiles on all platforms, can anybody give feedback on that? |
Can someone verify this that has a Xenial system handy? Also, don't forget to update the installation (binary and source) guide on the wiki. Also for macOS and manually install these on the macOS Jenkins nodes. |
|
didn't check for symbol collision, but so far: |
|
Yep, I know that several ROS1 packages depend on tinyxml2 while several low level packages in ROS depend on tinyxml. They are different packages and can coexist without problem |
This installs
libtinyxml-devandlibeigen3-devas a dependency on the linux docker.For mac, we have to install these packages via homebrew, for windows, we are currently in the process of writing choco packages for it.