Sets the nightly clang_libcxx job to use rcl_logging_noop#291
Merged
dirk-thomas merged 2 commits intoros2:masterfrom May 10, 2019
Merged
Sets the nightly clang_libcxx job to use rcl_logging_noop#291dirk-thomas merged 2 commits intoros2:masterfrom
dirk-thomas merged 2 commits intoros2:masterfrom
Conversation
When building with libc++ the rcl package will fail to link because it can't find the Log4cxx functions used by rcl_logging_log4cxx. This change sets a build argument to use the rcl_logging_noop logger instead of the default one.
Contributor
Author
|
I have been able to test this locally on a linux machine. Without the new cmake arg it fails when compiling with clang and libc++, but succeeds when the new cmake arg is added. This should be ready for review. |
dirk-thomas
approved these changes
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with libc++ the rcl package will fail to link because it can't find the Log4cxx functions used by rcl_logging_log4cxx.
This is causing the nightly CI build for linux_clang_libcxx to fail: https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/45/
See conversation here: ros2/rcl_logging#9 (comment)
This change sets a build argument to use the rcl_logging_noop logger instead of the default one.
I had explored building log4cxx from source with clang and libc++ to resolve this, but ran into issues with getting the Apache Runtime Environment to build. Because of this, we think that it is not worth the extra work to get rcl_logging_log4cxx working just for the nightly build at this point. I've created a new Github issue to track enabling this use case in rcl_logging_log4cxx later (ros2/rcl_logging#14).