Conversation
Member
Author
|
CI which utilizes log4cxx (from ros2/rcl_logging#3)
|
cottsay
approved these changes
Feb 21, 2019
Member
cottsay
left a comment
There was a problem hiding this comment.
Looks like liblog4cxx-dev is present for xenial, and bionic and newer. LGTM.
14b7295 to
0067350
Compare
added 2 commits
February 21, 2019 13:52
Needed in support of: ros2/rcl_logging#3
Member
Author
|
Rerun after rebase:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also unwrap the dependency line to make diffs better.