You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 4, 2021. It is now read-only.
Overnight, it looks like all of the nightly jobs started going yellow (example: http://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_debug/261). It looks like there is a new flake8 warning that is occurring on nearly every piece of python code in ROS2; that warning looks like this:
./ros2cli/plugin_system.py:21:1: I202 Additional newline in a section of imports.
from ros2cli.entry_points import load_entry_points
^
./ros2cli/node/daemon.py:26:1: I202 Additional newline in a section of imports.
from xmlrpc.client import ProtocolError
^
2 I202 Additional newline in a section of imports.
In all cases that I looked at, the code in question looks something like:
from nose.tools import assert_raises
from rosidl_parser import Type
If I get rid of that newline, then the warning goes away, but I actually find the newline helpful to separate out groups of imports. @ros2/team what is your opinion? Should I fix all of these violations, or should we disable the I202 warning?
Overnight, it looks like all of the nightly jobs started going yellow (example: http://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_debug/261). It looks like there is a new flake8 warning that is occurring on nearly every piece of python code in ROS2; that warning looks like this:
In all cases that I looked at, the code in question looks something like:
If I get rid of that newline, then the warning goes away, but I actually find the newline helpful to separate out groups of imports. @ros2/team what is your opinion? Should I fix all of these violations, or should we disable the
I202warning?