Follow up of #3.
At the moment the function get_coordinated_domain_id returns an object wrapping a socket and mentions in the docblock that it relies on the garbage collector to destroy the socket when no references are hold anymore. Since in Python the garbage collector might run anytime (or never) this isn't a viable API.
During the tests even a warning is printed that the sockets are never being closed: https://ci.ros2.org/view/All/job/test_ci_windows/196/pytest-warnings/
@pbaughman Since you create the original pull request implementing this API can you please look into this and revise the API in a follow up PR to make it explicit and deterministic?
Follow up of #3.
At the moment the function
get_coordinated_domain_idreturns an object wrapping a socket and mentions in the docblock that it relies on the garbage collector to destroy the socket when no references are hold anymore. Since in Python the garbage collector might run anytime (or never) this isn't a viable API.During the tests even a warning is printed that the sockets are never being closed: https://ci.ros2.org/view/All/job/test_ci_windows/196/pytest-warnings/
@pbaughman Since you create the original pull request implementing this API can you please look into this and revise the API in a follow up PR to make it explicit and deterministic?