Skip to content

Added missing: #include <QSet>#30

Closed
fxkrait wants to merge 1 commit intoros-visualization:masterfrom
fxkrait:master
Closed

Added missing: #include <QSet>#30
fxkrait wants to merge 1 commit intoros-visualization:masterfrom
fxkrait:master

Conversation

@fxkrait
Copy link
Copy Markdown

@fxkrait fxkrait commented Dec 24, 2019

failed to compile.
See: ros-melodic-arch/ros-melodic-rqt-image-view#1
And #29 : #29

@cubimon
Copy link
Copy Markdown
Contributor

cubimon commented Jan 2, 2020

Please notice me senpai @dirk-thomas

@jwhendy
Copy link
Copy Markdown

jwhendy commented Jan 5, 2020

This change allows the package to build on arch linux for me.

@dirk-thomas
Copy link
Copy Markdown
Contributor

I don't think this patch is sufficient as is. The header image_view.h also uses QSet and is being included by the .cpp file. If the .cpp fails to compile downstream packages should fail when trying to use the header file. Therefore I think the missing include should be moved to the header instead.

@cubimon
Copy link
Copy Markdown
Contributor

cubimon commented Jan 8, 2020

@GregHab can you move the include statement to the header? It makes more sense

@dirk-thomas
Copy link
Copy Markdown
Contributor

Replaced by #31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants