Skip to content

avoid deprecated api#28

Merged
dirk-thomas merged 2 commits intoros-visualization:crystal-develfrom
Karsten1987:avoid_deprecated_api
Jul 15, 2019
Merged

avoid deprecated api#28
dirk-thomas merged 2 commits intoros-visualization:crystal-develfrom
Karsten1987:avoid_deprecated_api

Conversation

@Karsten1987
Copy link
Copy Markdown
Contributor

Signed-off-by: Karsten Knese karsten.knese@us.bosch.com

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@dirk-thomas
Copy link
Copy Markdown
Contributor

@Karsten1987 The patch fails to compile - see CI.

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
Copy link
Copy Markdown
Contributor Author

indeed, the deprecation was introduced at qt version 5.11.0. I opted for a #if/#else to react accordingly to the version. Let me know if you'd prefer another method.

@dirk-thomas
Copy link
Copy Markdown
Contributor

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 9b4efee into ros-visualization:crystal-devel Jul 15, 2019
@Karsten1987 Karsten1987 deleted the avoid_deprecated_api branch July 15, 2019 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants