FindPython3 explicitly instead of FindPythonInterp implicitly#254
Merged
FindPython3 explicitly instead of FindPythonInterp implicitly#254
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Member
I think |
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
|
CI (build:
|
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
|
Rerun of CI
|
nuclearsandwich
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
qt_gui_cppuseFindPython3. Currently this code implicitly depends onament_cmake_corefindingFindPythonInterpfor it.@cottsay this PR needs a rolling specific branch such asedit: main branch createdmaster/main/rolling-devel. Personally I likemain, any preferences yourself?Marking as draft because this PR needs changes inedit: Those have been merged ros-visualization/python_qt_binding#107python_qt_bindingto depend onFindPython3Related to ros2/python_cmake_module#6
Blocks ament/ament_cmake#355