support building on Xenial with TinyXML2 version 2.2#169
Merged
dirk-thomas merged 2 commits intocrystal-develfrom Jan 25, 2019
Merged
support building on Xenial with TinyXML2 version 2.2#169dirk-thomas merged 2 commits intocrystal-develfrom
dirk-thomas merged 2 commits intocrystal-develfrom
Conversation
a6d70d1 to
8e0409a
Compare
Contributor
Author
|
Ready for review. |
Contributor
|
I'm not familiar enough with c++ templates to provide any real feedback on the code. Is there a test to show this also is compatible with bionic? |
Contributor
Author
The PR built successfully on Bionic. |
brawner
approved these changes
Jan 24, 2019
Contributor
brawner
left a comment
There was a problem hiding this comment.
Like I mentioned, not familiar enough with template codes to understand the implications. But looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #147.
@brawner FYI