Skip to content

[melodic] Adding SIP 5 integration.#94

Closed
seanyen wants to merge 1 commit intoros-visualization:melodic-develfrom
seanyen:seanyen/sip5
Closed

[melodic] Adding SIP 5 integration.#94
seanyen wants to merge 1 commit intoros-visualization:melodic-develfrom
seanyen:seanyen/sip5

Conversation

@seanyen
Copy link
Copy Markdown

@seanyen seanyen commented Aug 7, 2020 •
edited
Loading

This is an attempt to implement SIPv5 integration. Since SIPv5, it started to implement PEP 517 compliant backend and stopped releasing sipconfig module.

To integrate with it, one can define PEP 518 (a.k.a., pyproject.toml) project file to describe the SIP build. And here are the minimum requirement to run:

And here is some highlights of my verification environment:

  • Windows 10
  • Python 3.8.3 (pip-20.2.1, setuptools-49.2.1)
  • Qt5 5.15.0 (Vcpkg port)
  • Installed python modules:
PyQt-builder==1.4.0
PyQt5==5.15.0
PyQt5-sip==12.8.0
sip==5.3.0

@dirk-thomas
Copy link
Copy Markdown
Contributor

dirk-thomas commented Aug 7, 2020

Can you please provide some more context: e.g. what minimum version of sip / setuptools is required for this patch to work, if you have verified this still work on e.g. Ubuntu with the Debian packages or with a newer version of SIP, etc.

@seanyen
Copy link
Copy Markdown
Author

seanyen commented Aug 8, 2020

@dirk-thomas I tried to capture the minimum requirements specified on the book (also added more matrix on Windows side). For the Linux validation, I found it is little bit tricky to have a system with Qt>=5.14 plus all other Python required modules. Please excuse my limited knowledge on Linux side, do you just happen to know what distro \ release I can begin with first to get a closer environment?

@jspricke
Copy link
Copy Markdown
Contributor

jspricke commented Sep 28, 2020

@seanyen Debian unstable/testing has all the packages in the required versions.

@wjwwood wjwwood mentioned this pull request Apr 15, 2021
Open
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Jul 21, 2021

@seanyen Is this PR still relevant after #95 and #105?

@lopsided98
Copy link
Copy Markdown
Contributor

lopsided98 commented Jul 22, 2021

I think this PR is still required to build python_qt_binding with SIP >=5. SIP 4 is currently still required to build this package, those other PRs just allow this package to work in combination with PyQt5 built with SIP >=5.

@v4hn v4hn mentioned this pull request Feb 14, 2022
Merged
@pryre pryre mentioned this pull request Jun 3, 2023
Closed
@scrouthtv scrouthtv mentioned this pull request Jan 16, 2025
Open
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Apr 2, 2025

Thank you for the PR! Melodic is EOL, so i'm going to close this one.

@sloretz sloretz closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seanyen @dirk-thomas @jspricke @sloretz @lopsided98