[Fix] Replace PythonInterp to Python3 COMPONENTS#108
Merged
clalancette merged 1 commit intoros-visualization:mainfrom Nov 29, 2021
homalozoa:main
Merged
[Fix] Replace PythonInterp to Python3 COMPONENTS#108clalancette merged 1 commit intoros-visualization:mainfrom homalozoa:main
clalancette merged 1 commit intoros-visualization:mainfrom
homalozoa:main
Conversation
Member
|
This appears to resolve recent issues I'm seeing on Fedora and RHEL 8.5. Thanks for the patch!
|
cottsay
approved these changes
Nov 13, 2021
Member
cottsay
left a comment
There was a problem hiding this comment.
The warnings on RHEL are expected and not related to this change.
Thanks for the patch!
sloretz
requested changes
Nov 22, 2021
1. Replace PythonInterp & PythonLibs to COMPONENTS 2. Replace PYTHON_INCLUDE_DIRS to Python3_INCLUDE_DIRS 3. Replace PYTHON_EXECUTABLE to Python3_EXECUTABLE Signed-off-by: Homalozoa <nx.tardis@gmail.com>
sloretz
approved these changes
Nov 23, 2021
Member
|
Fresh CI:
I'd be fascinated to know why the other CI run didn't fail, but successfully resolved the issue on RHEL. |
Contributor
|
All of the failures are in |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As description in https://cmake.org/cmake/help/v3.12/module/FindPythonLibs.html and https://cmake.org/cmake/help/v3.12/module/FindPythonInterp.html . Using find_package(PythonLib) and find_package(PythonInterp) are deprecated.
Also, ${PYTHON_VERSION_MAJOR} and ${PYTHON_VERSION_MINOR} are not result variables of FindPython3. ${Python3_VERSION}, ${Python3_VERSION_MAJOR} and ${Python3_VERSION_MINOR} are new variables.
Signed-off-by: Homalozoa nx.tardis@gmail.com