Use magic $(MAKE) variable to suppress build warning#91
Merged
dirk-thomas merged 1 commit intoros-visualization:melodic-develfrom May 26, 2020
Merged
Use magic $(MAKE) variable to suppress build warning#91dirk-thomas merged 1 commit intoros-visualization:melodic-develfrom
dirk-thomas merged 1 commit intoros-visualization:melodic-develfrom
Conversation
According to the gnu make documentation, a subprocess make should use the $(MAKE) variable or +make to tell the parent make process that the child is actually a make process as well. This is required to suppress the warning `warning: jobserver unavailable: using -j1. Add `+' to parent make rule.`
Contributor
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
May 26, 2020
According to the gnu make documentation, a subprocess make should use the $(MAKE) variable or +make to tell the parent make process that the child is actually a make process as well. This is required to suppress the warning `warning: jobserver unavailable: using -j1. Add `+' to parent make rule.`
Contributor
|
Cherry-picked to |
|
This leads to a cmake error on my machine: I am not sure why the |
Contributor
Author
|
According to the GNU documentation, the command in the makefile should read In cmake the dollar needs to be escaped with a backslash in order to be not interpreted by cmake. |
|
You are right, I would not have expected that: ninja-build/ninja#1140 |
|
Or maybe that issue is more related: https://gitlab.kitware.com/cmake/cmake/-/issues/18062 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the gnu make documentation, a subprocess make should use the
$(MAKE)variable or+maketo tell the parentmakeprocess that the child is actually amakeprocess as well.This is required to suppress the warning:
warning: jobserver unavailable: using -j1. Add+' to parent make rule.`