Fix linking with non framework builds of qt (e.g. from conda-forge)#84
Merged
dirk-thomas merged 4 commits intoros-visualization:crystal-develfrom May 26, 2020
Conversation
Contributor
Author
|
👋 @dirk-thomas, |
Contributor
Author
|
Hello @dirk-thomas, can you take a look at PR, please? |
…workBuildsOnMacOS
|
Works perfectly for me! |
Contributor
|
Thanks for the patch. |
|
Will this be backported to melodic/noetic? |
Contributor
Not automatically. Thanks for bringing it up. Done in 5c2f6d9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add auto-detection if qt was built with frameworks option on by probing for QtCore.framework existence
Add renaming of libraries to link from Qt* to Qt5* for darwin if non-framework build is used