Check for Homebrew's PyQt5 install path#57
Merged
mlautman merged 1 commit intocrystal-develfrom Dec 10, 2018
Merged
Conversation
mlautman
reviewed
Dec 3, 2018
31e0f2f to
d433b76
Compare
Member
|
Can you get this to pass a test so that we can merge it? |
Contributor
Author
|
@mlautman Here is a test for the default situation. I'll work with Dirk to test the new condition |
dirk-thomas
approved these changes
Dec 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the logic in sip_configure to also check for Homebrew's sip file location. Previous ROS2 MacOS instructions said to symlink PyQt5 -> Qt5, but that's not necessary with this PR.