Fixing auto lint tests and making one flake8 change#55
Merged
brawner merged 1 commit intocrystal-develfrom Nov 20, 2018
Merged
Conversation
mlautman
approved these changes
Nov 20, 2018
Contributor
|
Why should the |
9a1e316 to
ce483bd
Compare
Contributor
Author
|
@dirk-thomas Gah, it shouldn't have been. I've restored that test. |
dirk-thomas
approved these changes
Nov 20, 2018
Contributor
|
Please use squash merge and delete obsolete branches afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the added python style check files in favor of ament_lint_auto. It also fixes one flake8 issue that snuck through.
CI test
https://ci.ros2.org/job/ci_linux/5596