Skip to content

Modifying sip_configure for improper lib names#54

Merged
mlautman merged 2 commits intocrystal-develfrom
ros2_sip_configure
Nov 2, 2018
Merged

Modifying sip_configure for improper lib names#54
mlautman merged 2 commits intocrystal-develfrom
ros2_sip_configure

Conversation

@brawner
Copy link
Copy Markdown
Contributor

@brawner brawner commented Nov 1, 2018

This adds a check to sip_configure.py for whether the lib name is None, an empty string or whitespace.

For example, when I build qt_gui_cpp this is the diff for the qt_gui_cpp_sip.so Makefile if I ask CMakeLists to find_package(Boost...) (even if the code doesn't use it) and if I don't.

< With find_package(Boost)
> Without find_package(Boost)
< LIBS = -Flib -Llib -F/usr/local/Cellar/qt/5.11.2/lib -L/usr/local/Cellar/qt/5.11.2/lib /usr/local/lib/libboost_filesystem-mt.dylib /usr/local/lib/libboost_system-mt.dylib -framework QtCore -framework DiskArbitration -framework IOKit -framework QtGui -F$$[QT_INSTALL_LIBS] -framework QtCore -framework DiskArbitration -framework IOKit -framework QtWidgets -framework QtPrintSupport
---
> LIBS = -Flib -Llib -F/usr/local/Cellar/qt/5.11.2/lib -L/usr/local/Cellar/qt/5.11.2/lib -l -framework QtCore -framework DiskArbitration -framework IOKit -framework QtGui -F$$[QT_INSTALL_LIBS] -framework QtCore -framework DiskArbitration -framework IOKit -framework QtWidgets -framework QtPrintSupport

Or condensed:

< LIBS = -Flib -Llib ... libboost_system-mt.dylib -framework QtCore ...
---
> LIBS = -Flib -Llib ... qt/5.11.2/lib -l -framework QtCore...

And this is the line from the Makefile with this bug fix

< LIBS = -Flib -Llib ... qt/5.11.2/lib -framework QtCore ...

@ghost ghost assigned brawner Nov 1, 2018
@ghost ghost added the in progress label Nov 1, 2018
@mlautman mlautman merged commit a6cba30 into crystal-devel Nov 2, 2018
@ghost ghost removed the in progress label Nov 2, 2018
@mlautman mlautman deleted the ros2_sip_configure branch November 2, 2018 21:31
dirk-thomas pushed a commit that referenced this pull request Sep 30, 2019
@brawner @dirk-thomas
Modifying sip_configure (#54)
97be6f5
@dirk-thomas dirk-thomas mentioned this pull request Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brawner brawner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brawner @dirk-thomas @mlautman