Merged
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Contributor
Author
|
Contributor
Author
|
The CMake version installed in rhel is: Trying a different approach
|
Contributor
Author
|
clalancette
approved these changes
Apr 25, 2024
Contributor
|
(and let's remember to backport this to Jazzy as well) |
Contributor
|
@Mergifyio backport jazzy |
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
* Older CMake doesn't have the policy, so skip it there. Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 4fe5bce) # Conflicts: # cmake/shiboken_helper.cmake
clalancette
pushed a commit
that referenced
this pull request
Apr 25, 2024
* Older CMake doesn't have the policy, so skip it there. Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR #137 introduces a regresion. CMP0148 is new in CMake 3.27. The main CMakeLists.txt is using 3.5, I updated the cmake/shiboken_helper.cmake version to 3.5 too.