Skip to content

Fix flake8 linter regression#125

Merged
clalancette merged 1 commit intoros-visualization:rollingfrom
Crola1702:rolling
Mar 2, 2023
Merged

Fix flake8 linter regression#125
clalancette merged 1 commit intoros-visualization:rollingfrom
Crola1702:rolling

Conversation

@Crola1702
Copy link
Copy Markdown
Contributor

@Crola1702 Crola1702 commented Mar 2, 2023

Happening on all ros2 nightlies (linux-debug, aarch-debug, windows-debug)

Error message:

Import statements are in the wrong order. 'import os' should be before 'import platform':
import os

This was introduced in: #118

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 requested a review from sloretz as a code owner March 2, 2023 12:39
Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI. Thanks for taking care of this.

@Crola1702
Copy link
Copy Markdown
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 1e2994c into ros-visualization:rolling Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants