Fix deprecated sub callback warnings#84
Merged
wjwwood merged 1 commit intoros-visualization:ros2from Aug 21, 2021
aprotyas:aprotyas/deprecate-shared-ptr-sub-callback
Merged
Fix deprecated sub callback warnings#84wjwwood merged 1 commit intoros-visualization:ros2from aprotyas:aprotyas/deprecate-shared-ptr-sub-callback
wjwwood merged 1 commit intoros-visualization:ros2from
aprotyas:aprotyas/deprecate-shared-ptr-sub-callback
Conversation
This commit is necessitated by deprecation of the `void shared_ptr<T>` subscriber callback signature. As such, this commit migrates away from using said callbacks. Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
Author
|
Full CI:
|
Author
|
Yellow CI for Windows originates from |
wjwwood
approved these changes
Aug 21, 2021
Author
|
@wjwwood thanks for the review, can you merge please? |
Member
|
Oh yeah I guess these don't require the deprecation to go in first. |
87 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros2/rclcpp#1713 deprecates the
void shared_ptr<T>subscription callback signatures, so this PR migrates away from said signatures.Signed-off-by: Abrar Rahman Protyasha abrar@openrobotics.org