Skip to content

Bump all Windows binary releases to latest#834

Merged
christophebedard merged 1 commit intoros-tooling:mainfrom
minggangw:bump-ros2-for-windows
Jul 1, 2025
Merged

Bump all Windows binary releases to latest#834
christophebedard merged 1 commit intoros-tooling:mainfrom
minggangw:bump-ros2-for-windows

Conversation

@minggangw
Copy link
Copy Markdown
Contributor

@minggangw minggangw commented Jun 27, 2025 •
edited
Loading

This patch pumps the following ROS2 Windows releases to latest one:

  • humble
  • iron
  • jazzy
  • kilted

Signed-off-by: Minggang Wang minggangw@gmail.com

@minggangw minggangw requested a review from a team as a code owner June 27, 2025 08:11
@minggangw minggangw requested review from christophebedard and emersonknapp and removed request for a team June 27, 2025 08:11
christophebedard
christophebedard requested changes Jun 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also sign off your commit?

$ git commit --amend --no-edit

@minggangw minggangw force-pushed the bump-ros2-for-windows branch from b441cbb to cb60568 Compare June 30, 2025 02:40
@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Jun 30, 2025

The Signed-off-by: line is misformatted. The email address should be between <>. See some examples here: https://git-scm.com/docs/git-interpret-trailers

If you amend your commit and use -s or --signoff, it should add the sign-off line automatically.

@minggangw
Bump all Windows binary releases to latest
653f8ec 
- humble
- iron
- jazzy
- kilted

Signed-off-by: Minggang Wang <minggangw@gmail.com>
@minggangw minggangw force-pushed the bump-ros2-for-windows branch from cb60568 to 653f8ec Compare July 1, 2025 02:00
@minggangw
Copy link
Copy Markdown
Contributor Author

minggangw commented Jul 1, 2025

The Signed-off-by: line is misformatted. The email address should be between <>. See some examples here: https://git-scm.com/docs/git-interpret-trailers

If you amend your commit and use -s or --signoff, it should add the sign-off line automatically.

formatted, thanks!

christophebedard
christophebedard approved these changes Jul 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@christophebedard christophebedard merged commit 2fe5c11 into ros-tooling:main Jul 1, 2025
29 checks passed
@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Jul 1, 2025

Released as 0.7.15/v0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophebedard christophebedard christophebedard approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros-tooling/reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@minggangw @christophebedard