Skip to content

add jazzy support#863

Merged
christophebedard merged 3 commits intoros-tooling:masterfrom
ijnek:jazzy
Apr 28, 2024
Merged

add jazzy support#863
christophebedard merged 3 commits intoros-tooling:masterfrom
ijnek:jazzy

Conversation

@ijnek
Copy link
Copy Markdown
Contributor

@ijnek ijnek commented Apr 25, 2024

No description provided.

@ijnek ijnek requested a review from a team as a code owner April 25, 2024 01:30
@ijnek ijnek requested review from MichaelOrlov and emersonknapp and removed request for a team April 25, 2024 01:30
@ijnek ijnek mentioned this pull request Apr 25, 2024
Open
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.55%. Comparing base (3d43551) to head (03789af).
Report is 1 commits behind head on master.

❗ Current head 03789af differs from pull request most recent head 63184f4. Consider uploading reports for the commit 63184f4 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
- Coverage   45.69%   44.55%   -1.15%     
==========================================
  Files           2        2              
  Lines         302      303       +1     
  Branches       81       81              
==========================================
- Hits          138      135       -3     
- Misses        164      168       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

christophebedard
christophebedard reviewed Apr 25, 2024
View reviewed changes
Comment thread __tests__/ros-ci.test.ts Outdated
@christophebedard christophebedard mentioned this pull request Apr 25, 2024
Merged
@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Apr 25, 2024

https://github.com/ros-tooling/action-ros-ci/actions/runs/8825903214/job/24260098966?pr=863#step:16:826

I think this might be due to ros-tooling/setup-ros-docker#67

@ijnek
Copy link
Copy Markdown
Contributor Author

ijnek commented Apr 28, 2024

https://github.com/ros-tooling/action-ros-ci/actions/runs/8825903214/job/24260098966?pr=863#step:16:826

I think this might be due to ros-tooling/setup-ros-docker#67

So are we cool with ignoring this, or do you want this to be fixed in this PR?

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Apr 28, 2024

So are we cool with ignoring this, or do you want this to be fixed in this PR?

We can leave it for now

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Apr 28, 2024

Can you sign-off your last commit? Or squash all and sign-off.

ijnek added 3 commits April 27, 2024 20:23
@ijnek
add jazzy support
894ad46 
Signed-off-by: ijnek <kenjibrameld@gmail.com>
@ijnek
change rolling repos file to noble repos file so we can reuse it with…
ff7ba1f 
… jazzy

Signed-off-by: ijnek <kenjibrameld@gmail.com>
@ijnek
Undo whitespace changes
63184f4 
Signed-off-by: ijnek <kenjibrameld@gmail.com>
christophebedard
christophebedard approved these changes Apr 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'll release this as 0.3.8.

@christophebedard christophebedard merged commit b418fc0 into ros-tooling:master Apr 28, 2024
@ijnek
Copy link
Copy Markdown
Contributor Author

ijnek commented Apr 28, 2024

No problem, thanks for maintaining these packages @christophebedard !

@christophebedard christophebedard mentioned this pull request May 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophebedard christophebedard christophebedard approved these changes

@emersonknapp emersonknapp Awaiting requested review from emersonknapp emersonknapp is a code owner automatically assigned from ros-tooling/reviewers

@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov MichaelOrlov is a code owner automatically assigned from ros-tooling/reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ijnek @christophebedard