Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

[melodic] updated install for better portability.#973

Merged
mikeferguson merged 2 commits intoros-planning:melodic-develfrom
seanyen:seanyen/install
Mar 11, 2020
Merged

[melodic] updated install for better portability.#973
mikeferguson merged 2 commits intoros-planning:melodic-develfrom
seanyen:seanyen/install

Conversation

@seanyen
Copy link
Contributor

@seanyen seanyen commented Mar 11, 2020

This pull request is to install the library to the correct location for Windows.

The change adheres with the catkin guide:
https://docs.ros.org/api/catkin/html/howto/format1/building_libraries.html#installing
https://docs.ros.org/api/catkin/html/howto/format1/building_executables.html#installing

@seanyen
Copy link
Contributor Author

seanyen commented Mar 11, 2020

@mikeferguson This is ready for review and merge. Thanks.

@mikeferguson mikeferguson merged commit 313998d into ros-planning:melodic-devel Mar 11, 2020
@mikeferguson
Copy link
Contributor

Thanks! I don't know much about your windows release mechanism - do you need a new tagged release in order to actually use this?

@seanyen seanyen deleted the seanyen/install branch March 11, 2020 17:46
@seanyen
Copy link
Contributor Author

seanyen commented Mar 12, 2020

@mikeferguson Leave it at the upstream is fine for now. https://aka.ms/ros is building everything from upstream. Feel free to stick with the regular release cadence.

Btw, I will be soon move my focus to noetic and expect more migration changes to come. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants