Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

fix boundary point exclusion in convexFillCells#1095

Merged
mikeferguson merged 1 commit intoros-planning:noetic-develfrom
ChristofDubs:convexFillCells-boundary-fix
Mar 3, 2021
Merged

fix boundary point exclusion in convexFillCells#1095
mikeferguson merged 1 commit intoros-planning:noetic-develfrom
ChristofDubs:convexFillCells-boundary-fix

Conversation

@ChristofDubs
Copy link
Contributor

A bug in the function that returns all the cells contained in a (convex) polygon:

  • sorts all the points along the polygon outline by x coordinate
  • for all points with same x coordinate, find min and max y coordinate
  • for that x coordinate, considers all points between min and max y coordinate to be within the polygon

The bug is that the maximum y coordinate also needs to be included.

@mikeferguson mikeferguson merged commit 996ccec into ros-planning:noetic-devel Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants