Skip to content

Install nodelet plugin descriptor file as well.#56

Merged
mikaelarguedas merged 1 commit intoros-perception:hydro-develfrom
gavanderhoorn:install_nodelet_plugin_xml
Jan 24, 2018
Merged

Install nodelet plugin descriptor file as well.#56
mikaelarguedas merged 1 commit intoros-perception:hydro-develfrom
gavanderhoorn:install_nodelet_plugin_xml

Conversation

@gavanderhoorn
Copy link
Copy Markdown
Contributor

This seems to have been missed in #41.

Related ROS Answers question: pointcloud_to_laserscan: "Skipping XML Document..." (note that the problem is here, in gmapping, not in pointcloud_to_laserscan).

Fixes #55.

Without this, from-source builds in devel spaces will work fine, but the binary debians will not contain the required plugin descriptor file.

This will need a new release on all platforms.

Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I'll leave to @vrabaud to merge and release.

@gavanderhoorn
Copy link
Copy Markdown
Contributor Author

@vrabaud: very gentle 🛎.

@furushchev
Copy link
Copy Markdown

+1 to be merged.
On kinetic, just installing this package collapses all nodelet functions.

@josiahls
Copy link
Copy Markdown

Hi, I am having this same issue:
[ERROR] [1510694438.414259937]: Skipping XML Document "/opt/ros/kinetic/share/gmapping/nodelet_plugins.xml" which had no Root Element. This likely means the XML is malformed or missing.

This occurs when trying do an rviz turtlebot minimal launch. Won't let rvis continue without this. I have the gmapping version 1.3.9, and I looked at the file location and there is still no nodelet_plugins.xml. Is this fix in version 1.3.9 or is this still waiting for a newer release?

@gavanderhoorn
Copy link
Copy Markdown
Contributor Author

gavanderhoorn commented Nov 15, 2017

@josiahls wrote:

I have the gmapping version 1.3.9, and I looked at the file location and there is still no nodelet_plugins.xm

this PR hasn't been merged yet, so it is not part of any release.

Building it from source in an overlay workspace would allow you to use the fixed version immediately.

@mikaelarguedas
Copy link
Copy Markdown
Contributor

👍 it would be great to get this merged and released

@garyservin
Copy link
Copy Markdown

+1

1 similar comment
@fmessmer
Copy link
Copy Markdown

👍

@gavanderhoorn
Copy link
Copy Markdown
Contributor Author

gavanderhoorn commented Dec 1, 2017

Could this get merged? I'm not really personally affected by this, but there are a nr of questions popping up on ROS Answers about issues that in the end turn out to be caused by pluginlib giving up because of the missing xml file.

ros/pluginlib#85 mitigates that, but only so much.

@mikaelarguedas
Copy link
Copy Markdown
Contributor

pluginlib's fix has been released and synced in lunar. It should make it to the main repo for kinetic in the upcoming sync.

But I agree with @gavanderhoorn it would be really great to get this merged ans released soon 👍

@elhayra
Copy link
Copy Markdown

elhayra commented Dec 25, 2017

+1

@eraserpencil
Copy link
Copy Markdown

Pardon my ignorance. Has the fix been synced? How do I check if it has?

@gavanderhoorn
Copy link
Copy Markdown
Contributor Author

@eraserpencil: no, it hasn't.

How do I check if it has?

at the very least this PR should have a status merged, instead of open.

@gavanderhoorn
Copy link
Copy Markdown
Contributor Author

@wjwwood: would it be an option to merge this in? With ros/pluginlib#85 merged it's less of an issue in case you don't want to use gmapping, but without manually adding the changes in this PR, the gmapping nodelet of even a source build is unusable.

@QinZiwen
Copy link
Copy Markdown

I am having this same issue:
[ERROR] [1516671310.130156638]: Skipping XML Document "/opt/ros/indigo/share/gmapping/nodelet_plugins.xml" which had no Root Element. This likely means the XML is malformed or missing.

I did not find a solution to this problem, and I use indigo

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jan 23, 2018

@gavanderhoorn it is an option, but I'd rather the maintainer handle this (I have too many packages to do this kind of thing on all of them):

lgtm, but I'll leave to @vrabaud to merge and release.

@gavanderhoorn
Copy link
Copy Markdown
Contributor Author

I agree completely, but it seems @vrabaud is a bit busy :)

@skyinzero
Copy link
Copy Markdown

skyinzero commented Jan 23, 2018

@gavanderhoorn excuse me,where is gmapping/CMakeLists.txt. I mean, the path of gmapping/CMakeLists.txt. thx!

@gavanderhoorn
Copy link
Copy Markdown
Contributor Author

gavanderhoorn commented Jan 23, 2018

here?

But know that you won't find it if you installed gmapping using apt-get.

@skyinzero
Copy link
Copy Markdown

@gavanderhoorn got it. thx!!!! : )

@mikaelarguedas
Copy link
Copy Markdown
Contributor

wjwwood: would it be an option to merge this in? With ros/pluginlib#85 merged it's less of an issue in case you don't want to use gmapping, but without manually adding the changes in this PR, the gmapping nodelet of even a source build is unusable.

I got green light from @vrabaud to merge and release this, as 1.3.9 is in all active distros I'll release on all of them so that it makes it into the next sync

@mikaelarguedas mikaelarguedas merged commit 1f16d3c into ros-perception:hydro-devel Jan 24, 2018
@mikaelarguedas
Copy link
Copy Markdown
Contributor

Released in Indigo, Kinetic and Lunar

@QinZiwen
Copy link
Copy Markdown

QinZiwen commented Jan 24, 2018

@mikaelarguedas You mean is that this problem can be solved by reinstalling ros-indigo?
Problem is:

[ERROR]: Skipping XML Document "/opt/ros/indigo/share/gmapping/nodelet_plugins.xml" which had no Root Element. This likely means the XML is malformed or missing.

Reinstall ros-indigo:

sudo apt-get install ros-indigo-desktop

@gavanderhoorn gavanderhoorn deleted the install_nodelet_plugin_xml branch January 24, 2018 08:18
@gavanderhoorn
Copy link
Copy Markdown
Contributor Author

@QinZiwen: no, you just need to install the upgraded packages that will be made available in the next public sync, or use the shadow repository if you can't wait.

@gavanderhoorn
Copy link
Copy Markdown
Contributor Author

Thanks @mikaelarguedas.

@QinZiwen
Copy link
Copy Markdown

Thanks @gavanderhoorn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.