Skip to content

Updated deprecated message filter headers#94

Merged
ahcorde merged 2 commits intorollingfrom
ahcorde/rolling/message_filter_deprecated_c_headers
Jul 19, 2024
Merged

Updated deprecated message filter headers#94
ahcorde merged 2 commits intorollingfrom
ahcorde/rolling/message_filter_deprecated_c_headers

Conversation

@ahcorde
Copy link
Copy Markdown
Collaborator

@ahcorde ahcorde commented Jul 15, 2024

Related with this PR ros2/message_filters#135

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
#include <message_filters/sync_policies/approximate_time.h>
#include <message_filters/synchronizer.h>
#include <message_filters/subscriber.hpp>
#include <message_filters/sync_policies/approximate_time.hpp>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR's CI seems to not like the ordering here.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from CursedRock17 July 18, 2024 20:42
@ahcorde
Copy link
Copy Markdown
Collaborator Author

ahcorde commented Jul 18, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Copy Markdown

@CursedRock17 CursedRock17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde ahcorde merged commit a4a3ce4 into rolling Jul 19, 2024
@ahcorde ahcorde deleted the ahcorde/rolling/message_filter_deprecated_c_headers branch July 19, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants