Conversation
|
@CursedRock17 looks like tests are failing |
|
I should mention this is meant to be a preemptive PR for if/when the related pull request gets approved. I'm also working on a backport so there won't be distribution issues. |
|
With the recent backports merged, this PR should be good for review. |
|
Hi @jonbinney, when you merge this PR, do you mind to create a new release on rolling ? |
|
Will do - i'll take a look this weekend. |
|
Looks like tests are still failing.... when did the |
|
It looks like the changes to the tf2 package got released, but aren't yet in the docker containers used by the CI. |
|
Yeah, even in the rolling container only tf2 version We could update CI to |
|
I lost track of this PR for a while, but looks like the same fix was merged in https://github.com/ros-perception/laser_filters/pull/226/files , so I'm closing this. |
Related to this pull request in
geometry2in which we deprecated the.hstyle headers in favor of.hpp.