Skip to content

Deprecate c headers#206

Closed
CursedRock17 wants to merge 3 commits intoros-perception:ros2from
CursedRock17:deprecate_c_headers
Closed

Deprecate c headers#206
CursedRock17 wants to merge 3 commits intoros-perception:ros2from
CursedRock17:deprecate_c_headers

Conversation

@CursedRock17
Copy link
Copy Markdown

Related to this pull request in geometry2 in which we deprecated the .h style headers in favor of .hpp.

@jonbinney
Copy link
Copy Markdown
Contributor

@CursedRock17 looks like tests are failing

@CursedRock17
Copy link
Copy Markdown
Author

I should mention this is meant to be a preemptive PR for if/when the related pull request gets approved. I'm also working on a backport so there won't be distribution issues.

@CursedRock17
Copy link
Copy Markdown
Author

With the recent backports merged, this PR should be good for review.

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Dec 27, 2024

Hi @jonbinney, when you merge this PR, do you mind to create a new release on rolling ?

@jonbinney
Copy link
Copy Markdown
Contributor

Will do - i'll take a look this weekend.

@jonbinney
Copy link
Copy Markdown
Contributor

Looks like tests are still failing.... when did the hpp headers get added to tf2?

@jonbinney
Copy link
Copy Markdown
Contributor

It looks like the changes to the tf2 package got released, but aren't yet in the docker containers used by the CI.

@jonbinney
Copy link
Copy Markdown
Contributor

Yeah, even in the rolling container only tf2 version 0.38.2 is included

root@ec5d52105e46:/# apt policy ros-rolling-tf2
ros-rolling-tf2:
  Installed: 0.38.2-1noble.20240919.213053
  Candidate: 0.38.2-1noble.20240919.213053
  Version table:
 *** 0.38.2-1noble.20240919.213053 100
        100 /var/lib/dpkg/status

We could update CI to apt upgrade before running, but I'd rather wait and merge this PR after the docker images get updated.

@jonbinney
Copy link
Copy Markdown
Contributor

I lost track of this PR for a while, but looks like the same fix was merged in https://github.com/ros-perception/laser_filters/pull/226/files , so I'm closing this.

@jonbinney jonbinney closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants