Add QoS overrides to stereo_image_proc#651
Add QoS overrides to stereo_image_proc#651JWhitleyWork merged 6 commits intoros-perception:rollingfrom audrow:audrow/add-qos-overrides
Conversation
|
We should make sure the CI jobs are green before merging. Since this change is not compatible with Foxy, we should probably branch (FYI @JWhitleyWork). For Rolling, we should make releases for the changes to image_common and message_filters (I can help with that); for Galactic it may require backporting those changes (I'll check when releasing for Rolling). |
|
I think I'm going to make a PR to |
|
@JWhitleyWork Friendly ping for review. It sounds like we may also want to re-target this to a new |
|
@ros-pull-request-builder retest this please |
|
Tested this on ros2 galactic and ros2 rolling. It builds and passes all tests. I made two small edits to the package.xml files in this PR. |
|
Re-targeted |
|
@ros-pull-request-builder retest this please |
1 similar comment
|
@ros-pull-request-builder retest this please |
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
This is adding QoS overrides, which were added in ros2/rclcpp#1408.
This PR relies on