Use newer 'add_on_set_parameters_callback' API#562
Merged
JWhitleyWork merged 1 commit intoros2from Jul 9, 2020
Merged
Conversation
The old API was deprecated in Foxy and since removed in ros2/rclcpp#1199. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Contributor
Author
|
Note, this should also resolve issues with the dev jobs mentioned in ros2/rclcpp#1199 (comment) |
JWhitleyWork
approved these changes
Jul 9, 2020
Collaborator
JWhitleyWork
left a comment
There was a problem hiding this comment.
Thanks for working on this! It was on my list but I hadn't worked on it yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old API was deprecated in Foxy and since removed in ros2/rclcpp#1199.