Replace rmq_qos_profile_t with rclcpp::QoS#1106
Merged
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
mikeferguson
reviewed
Jul 7, 2025
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Contributor
Author
|
can you take a look @asymingt ? |
mikeferguson
approved these changes
Jul 21, 2025
Member
mikeferguson
left a comment
There was a problem hiding this comment.
Looks good once CI passes (I presume we need to wait for the underlying changes to sync)
asymingt
approved these changes
Jul 21, 2025
| image_transport::TransportHints hints(this); | ||
| // Create subscriber with QoS matched to subscribed topic publisher | ||
| auto qos_profile = image_proc::getTopicQosProfile(this, topic); | ||
| rclcpp::QoS qos_profile = image_proc::getQosProfile(this, topic); |
There was a problem hiding this comment.
nit: There seems to be an inconsistency in this PR between whether we want to go auto qos_profile = ... or rclcpp::QoS qos_profile = .... It doesn't faze me which one we choose, but I think we should at least be internally consistent.
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Contributor
Author
|
testing is passing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with ros-perception/image_common#364