Deprecating tf2 C Headers#1039
Conversation
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
mikeferguson
left a comment
There was a problem hiding this comment.
We also shouldn't merge this until the actual geometry2 PR has been accepted upstream
| #include "tf2/LinearMath/Vector3.h" | ||
| #include "tf2/LinearMath/Quaternion.h" | ||
| #include "tf2/LinearMath/Vector3.hpp" | ||
| #include "tf2/LinearMath/Quaternion.hpp" |
There was a problem hiding this comment.
we should really wrap this with an if/else so that the branch continues to compile on older systems (since I expect this change to tf2 will only be released into rolling and later at this point):
#if __has_include(<tf2/convert.hpp>)
#include <tf2/convert.hpp>
#else
#include <tf2/convert.h>
#endif There was a problem hiding this comment.
we merged the cpp headers without the deprecation in humble and jazzy, I think it's save to merge this one
|
With the recent backports merged, this PR should be good for review. |
Changes in rolling are released in 0.40.0 - which is staged but not yet synced - CI won't pass until the next sync happens |
ahcorde
left a comment
There was a problem hiding this comment.
rolling testing is green, good to go!
Related to this pull request in
geometry2in which we deprecated the.hstyle headers in favor of.hpp.