Merged
Conversation
deleting robot package
* Add parameter to disable map server * Move parameter check to getParameters * Uncrustify * Don't mark static layer as current until we have a map * Make sure static layer gets initialized Make sure static layer gets initialized, even with an empty layer, so it doesn't crash if you disable the map service and enable the obstacle layer * remove map service from static layer Only use map topic instead Subscribe to map topic with default transient local volatility Add parameter "map_subscribe_transient_local" (default=true) for backwards compatibility with volatile publishers * Change AMCL to use only the map topic, not map service * remove now-unused MapServiceClient * uncrustify * only set current_=true when first map received * Fix nav2_costmap inflation tests. * Fixing collision tester test. * Revert "uncrustify" This reverts commit 82f88a7. This uncrustify failure is enforced differently depending on whether we are on the dashing branch or on the master branch. This particular commit is only appropriate on the dashing branch, but is already present there.
removing old maintainers from navigation1
* change primitives to recoveries * changing all over new bringups with nav2_recoveries * renaming primitive_name -> recovery_name
Robot class to util
…or nav doesnt work
* I added a timeout to spin_until_future_complete, so rviz doesn't get frozen if something goes wrong in the navigation stack. I did some changes in the start navigation; - changed the funtion type to boolean - added returns to the funtion, so it will return false if something goes wrong. I changed goal_tool added a if statement to check if start_navigation doesn't return false before calling any other functions in goal_tool * made the code cleaner and changed the error messages. Reduced the timeout value to 3 seconds. The timeouts will be parametrized in the future. * added timeout parameter
Build tools - Run build_all.sh from any nested repo workspace & rename dependencies workspace for "nav" autocomplete
* I added a timeout to spin_until_future_complete, so rviz doesn't get frozen if something goes wrong in the navigation stack. I did some changes in the start navigation; - changed the funtion type to boolean - added returns to the funtion, so it will return false if something goes wrong. I changed goal_tool added a if statement to check if start_navigation doesn't return false before calling any other functions in goal_tool * made the code cleaner and changed the error messages. Reduced the timeout value to 3 seconds. The timeouts will be parametrized in the future. * added timeout parameter * Update navigation_dialog.cpp * Update navigation_dialog.hpp * Update navigation_dialog.cpp * Update navigation_dialog.hpp
* Fixing typo in dependencies * Also remove some duplicate dependencies * Fixing robot_state_publisher dependency
* Add back parameter to configure DWA rate * Report out if we missed our control loop time.
All our builds have boost installed due to other dependencies, so we've never run into this. The build farm must build with all other dependencies removed somehow.
Signed-off-by: vinnamkim <vinnam.kim@gmail.com>
Author
|
The general consensus is this is good enough to release. I'm merging the PR to @SteveMacenski Can you please do a 0.2.3 release with the tip of dashing-devel when you get a chance? |
Member
|
@crdelsey sure thing, it probably won't happen before we talk this afternoon though |
Member
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the current 0.2.3 release candidate. This PR merges master onto the dashing-devel branch.
We expect a few more changes to be added to this PR as additional PRs get merged to master this week. The goal is to test this early next week and then merge to dashing-devel.