Fix tests after rolling sync 0225#5987
Conversation
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
| self, | ||
| goal_handle: ServerGoalHandle[NavigateToPose.Goal, | ||
| NavigateToPose.Result, NavigateToPose.Feedback] | ||
| NavigateToPose.Result, NavigateToPose.Feedback, |
There was a problem hiding this comment.
Previously: TypeError: Too few arguments for <class 'rclpy.action.server.ServerGoalHandle'>; actual 3, expected at least 4
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
| TEST_F(NonblockingSequenceTestFixture, test_failure_on_idle_child) | ||
| { | ||
| first_child_->changeStatus(BT::NodeStatus::IDLE); | ||
| // NodeExecutionError is introduced in BT.CPP 4.9.0 |
There was a problem hiding this comment.
This is not available in Kilted/Jazzy for now
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
SteveMacenski
left a comment
There was a problem hiding this comment.
Within BT Navigator, should we actually use this now to catch that and print some information about the failedNode / originalMessage https://github.com/BehaviorTree/BehaviorTree.CPP/blob/3ff6a32ba0497a08519c77a1436e3b81eff1bcd6/include/behaviortree_cpp/exceptions.h#L81 This seems like really nice information to give to a user.
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Good point, I think you are referring to this part right? |
Remove back-compatibility code for BT.CPP 3.8.x. Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
|
I think it's also time to remove navigation2/nav2_behavior_tree/src/behavior_tree_engine.cpp Lines 44 to 47 in 19a1240 They are false by default in newer versions |
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.