fix: Move SmootherParams declaration outside smooth_path conditional (backport #5473)#5475
Merged
SteveMacenski merged 1 commit intokiltedfrom Aug 21, 2025
Merged
Conversation
…5473) Fixes crash when dynamically changing smooth_path parameter from false to true. The issue occurred because SmootherParams were only declared when smooth_path was initially true, causing ParameterModifiedInCallbackException when trying to declare parameters within the dynamic parameter callback. Now SmootherParams are always declared, making them available for dynamic reconfiguration regardless of the initial smooth_path value. Fixes #5472 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> (cherry picked from commit 69a60df)
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
SteveMacenski
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crash when dynamically changing smooth_path parameter from false to true.
The issue occurred because SmootherParams were only declared when smooth_path was initially true, causing ParameterModifiedInCallbackException when trying to declare parameters within the dynamic parameter callback.
Now SmootherParams are always declared, making them available for dynamic reconfiguration regardless of the initial smooth_path value.
Fixes #5472
Generated with Claude Code
This is an automatic backport of pull request #5473 done by Mergify.