Skip to content

Verify that the updated path is not empty or placeholder. (backport #5009)#5014

Merged
SteveMacenski merged 1 commit intohumblefrom
mergify/bp/humble/pr-5009
Mar 24, 2025
Merged

Verify that the updated path is not empty or placeholder. (backport #5009)#5014
SteveMacenski merged 1 commit intohumblefrom
mergify/bp/humble/pr-5009

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 24, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4964
Primary OS tested on Ubuntu 24.04
Robotic platform tested on My robot, gz simulation
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Prevent the navigate_to_pose from failing due to a global planner failure while the local planner is running.

Description of documentation updates required from your changes

Description of how this change was tested

Trigger a situation where the global path cannot be generated by updating the global path through the RateController while the local planner is running.
I recreated this scenario by creating a narrow passage that is just wide enough not to be considered an obstacle due to cost, and attempted to make the robot pass through it.


Future work that may be required in bullet points

I'm also thinking we could adjust the return value of the RecoveryNode / RateController in this situation so that the PipelineSequence state is reset and we start from a clean place again so that FollowPath isn't considered running. That is the most clean solution if possible.
#4964 (comment)

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

This is an automatic backport of pull request #5009 done by [Mergify](https://mergify.com).

Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
(cherry picked from commit d9cc4ba)
@mergify
Copy link
Contributor Author

mergify bot commented Mar 24, 2025

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @humble, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski SteveMacenski merged commit 7ee3d2f into humble Mar 24, 2025
2 of 3 checks passed
@SteveMacenski SteveMacenski deleted the mergify/bp/humble/pr-5009 branch March 24, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants