Mppi goal to critic (backport #4822)#4853
Merged
SteveMacenski merged 2 commits intojazzyfrom Jan 14, 2025
Merged
Conversation
* Add goal pose to CriticData Signed-off-by: redvinaa <redvinaa@gmail.com> * Pass goal pose directly to withinPositionGoalTolerance Signed-off-by: redvinaa <redvinaa@gmail.com> * Fix condition not Signed-off-by: redvinaa <redvinaa@gmail.com> * Add goal positions to tests Signed-off-by: redvinaa <redvinaa@gmail.com> * Use plan stamp Signed-off-by: redvinaa <redvinaa@gmail.com> * Use float instead of auto Signed-off-by: redvinaa <redvinaa@gmail.com> * Throw nav2_core exceptions Signed-off-by: redvinaa <redvinaa@gmail.com> * Set pose frame id in test Signed-off-by: redvinaa <redvinaa@gmail.com> * Fix frame id in test vol 2 Signed-off-by: redvinaa <redvinaa@gmail.com> --------- Signed-off-by: redvinaa <redvinaa@gmail.com> (cherry picked from commit d11de56) # Conflicts: # nav2_mppi_controller/include/nav2_mppi_controller/tools/utils.hpp
Contributor
Author
|
Cherry-pick of d11de56 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
Author
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
SteveMacenski
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopen #4812 against main
This is an automatic backport of pull request #4822 done by Mergify.