Backport/wait for server timeout#4261
Merged
SteveMacenski merged 2 commits intoros-navigation:ironfrom Apr 21, 2024
Merged
Conversation
Contributor
|
@bektaskemal, all pull requests must be targeted towards the |
* Make BT nodes have configurable wait times. Previous solution provided hardcoded 1s value. Right now the value can be configured for BT Action, Cancel and Service nodes. [ros-navigation#3920] Signed-off-by: Adam Galecki <embeddedadam@gmail.com> * Make BT nodes have configurable wait times. Previous solution provided hardcoded 1s value. Right now the value can be configured for BT Action, Cancel and Service nodes. [ros-navigation#3920] Signed-off-by: Adam Galecki <embeddedadam@gmail.com> * Fix typos, linting errors and value type from float to int * Fix extra underscores * Fix extra underscore * Update unit tests with blackboard parameter Signed-off-by: Adam Galecki <embeddedadam@gmail.com> * Fix formatting errors Signed-off-by: Adam Galecki <embeddedadam@gmail.com> * Update system tests to match new parameter Signed-off-by: Adam Galecki <embeddedadam@gmail.com> --------- Signed-off-by: Adam Galecki <embeddedadam@gmail.com> Signed-off-by: Kemal Bektas <kemal.bektas@node-robotics.com>
…os-navigation#4178) Signed-off-by: Felix <felix@fzeltner.de> Co-authored-by: Felix <felix@fzeltner.de> Signed-off-by: Kemal Bektas <kemal.bektas@node-robotics.com>
335534e to
c0d2787
Compare
Member
|
This seems fine to me. Please run the full |
Contributor
Author
|
I tested locally and two test failed for me but they seems irrelevant: This one might be related to behaviortree_cpp_v3 version but I'm not sure. Here is the issue that error codes are in Goal and not Result, but this is wrong in iron branch: https://github.com/ros-planning/navigation2/blob/iron/nav2_system_tests/src/gps_navigation/tester.py#L187 |
SteveMacenski
approved these changes
Apr 21, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #3960 and #4178 to iron.
We would like to have this on iron if possible.