[collision monitor] Transient local durability for subscription to polygon topic#4207
Merged
SteveMacenski merged 1 commit intoros-navigation:mainfrom Mar 27, 2024
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
The
collision_monitorsubscriptions to topics<polygon_name>.polygon_sub_topiccan now have transient local durability QoS. I added the boolean parameter<polygon_name>.polygon_subscribe_transient_local(default value is false, to keep default QoS compatibility), to be able to set the QoS durability to transient local for polygon topic subscription.Description of documentation updates required from your changes
Added new parameter, so need to add that to default configs and documentation page
Future work that may be required in bullet points
For Maintainers: