Nav2 3954 consider robot footprint#3990
Closed
jwallace42 wants to merge 8 commits intoros-navigation:mainfrom
Closed
Nav2 3954 consider robot footprint#3990jwallace42 wants to merge 8 commits intoros-navigation:mainfrom
jwallace42 wants to merge 8 commits intoros-navigation:mainfrom
Conversation
SteveMacenski
requested changes
Nov 28, 2023
Member
|
Looks like the test failures are fixed with a pulling in of main or rebasing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3990 +/- ##
==========================================
- Coverage 90.41% 90.41% -0.01%
==========================================
Files 415 415
Lines 18569 18673 +104
==========================================
+ Hits 16789 16883 +94
- Misses 1780 1790 +10 ☔ View full report in Codecov by Sentry. |
621ca35 to
f47526f
Compare
f47526f to
69239a2
Compare
Contributor
|
This pull request is in conflict. Could you fix it @jwallace42? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
This pr adds functionality to invalidate a path based based on footprint checks. This functionality was added to the
isPathValidservice. A new parameter calledis_path_valid_check_footprintwas added to turn on/off the full footprint checks.Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: