Skip to content

Handle NaNs in AMCL beam sensor model#3929

Merged
SteveMacenski merged 2 commits intoros-navigation:mainfrom
hidmic:handle-nan-in-beam-model
Nov 3, 2023
Merged

Handle NaNs in AMCL beam sensor model#3929
SteveMacenski merged 2 commits intoros-navigation:mainfrom
hidmic:handle-nan-in-beam-model

Conversation

@hidmic
Copy link

@hidmic hidmic commented Nov 2, 2023

Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Primary OS tested on Ubuntu
Robotic platform tested on Data-driven benchmark

Description of contribution in a few bullet points

Pretty much what the title says. I accidentally came across this bug while running AMCL against a dataset with LaserScan messages that happened to bear NaNs every now and then.

Here I apply the same NaN check that the other sensor models use, for consistency.

Description of documentation updates required from your changes

None.


Future work that may be required in bullet points

None.

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants