Skip to content

Added missing virtual destructor#3813

Closed
VineetTambe wants to merge 1 commit intoros-navigation:mainfrom
VineetTambe:main
Closed

Added missing virtual destructor#3813
VineetTambe wants to merge 1 commit intoros-navigation:mainfrom
VineetTambe:main

Conversation

@VineetTambe
Copy link

@VineetTambe VineetTambe commented Sep 13, 2023

Basic Info

Added the missing empty virtual destructor which prevented package building of nav2_mppi_controller.

Info Please fill out this column
Ticket(s) this addresses -
Primary OS tested on Ubuntu 22.04
Robotic platform tested on ROS2 Humble + simulation setup used -> NeoBotix sim mp400 robot

Added the missing empty virtual destructor which prevented package building of nav2_mppi_controller.
A simple enough one-liner fix which allowed for the package to build

Description of documentation updates required from your changes

No documentation update required

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@VineetTambe
Copy link
Author

VineetTambe commented Sep 13, 2023

PR from main to main as opposed to the wrong branch in this PR

@VineetTambe VineetTambe mentioned this pull request Sep 13, 2023
Merged
7 tasks
@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2023

@VineetTambe, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@SteveMacenski
Copy link
Member

SteveMacenski commented Sep 13, 2023 •
edited
Loading

@VineetTambe heed the build failures. It already exists


  ~CriticManager() = default;

  /**
    * @brief Virtual Destructor for mppi::CriticManager
    */
  virtual ~CriticManager() = default;

@VineetTambe
Copy link
Author

VineetTambe commented Sep 13, 2023

@VineetTambe heed the build failures. It already exists


  ~CriticManager() = default;

  /**
    * @brief Virtual Destructor for mppi::CriticManager
    */
  virtual ~CriticManager() = default;

Very interesting. I am not sure why this change doesn't translate to the humble branch.
This PR is no longer needed I guess then? Sorry for wasting your time.

@SteveMacenski
Copy link
Member

SteveMacenski commented Sep 13, 2023

@VineetTambe is it only missing in Humble (what about Iron)?

If so, reopen the Humble (and Iron?) PR and I can merge. Sorry about the whiplash, I didn't know we already resolved this issue in Main :-)

@VineetTambe
Copy link
Author

VineetTambe commented Sep 13, 2023

Closing this PR and re-opening the previous one.

@VineetTambe
Copy link
Author

VineetTambe commented Sep 13, 2023

@VineetTambe is it only missing in Humble (what about Iron)?

If so, reopen the Humble (and Iron?) PR and I can merge. Sorry about the whiplash, I didn't know we already resolved this issue in Main :-)

@SteveMacenski it's only missing in humble for some reason. It is there in iron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees

No one assigned

Labels

backport-humble backport-iron

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VineetTambe @SteveMacenski