Skip to content

Fix goal_checker_plugin parameter format#3137

Merged
SteveMacenski merged 1 commit intoros-navigation:humblefrom
ipa-kut:fix/goal_checker_plugin
Aug 22, 2022
Merged

Fix goal_checker_plugin parameter format#3137
SteveMacenski merged 1 commit intoros-navigation:humblefrom
ipa-kut:fix/goal_checker_plugin

Conversation

@ipa-kut
Copy link
Copy Markdown
Contributor

@ipa-kut ipa-kut commented Aug 22, 2022

Basic Info

Info Please fill out this column
Tickets #3136
Primary OS tested on Ubuntu 22.04/20.04
Robotic platform tested on Multi robot gazebo simulation

Description of contribution in a few bullet points

Description of documentation updates required from your changes

None

Future work that may be required in bullet points

None

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 22, 2022

@ipa-kut, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @humble, but it must be in main
to have these changes reflected into new distributions.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Aug 22, 2022

@ipa-kut, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski changed the base branch from humble to main August 22, 2022 16:06
@SteveMacenski SteveMacenski changed the base branch from main to humble August 22, 2022 16:06
@SteveMacenski SteveMacenski merged commit 0bae341 into ros-navigation:humble Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ipa-kut @SteveMacenski