Skip to content

Cleanup CircleCI config#1934

Merged
ruffsl merged 9 commits intoros-navigation:masterfrom
ruffsl:ci-retest-2
Aug 11, 2020
Merged

Cleanup CircleCI config#1934
ruffsl merged 9 commits intoros-navigation:masterfrom
ruffsl:ci-retest-2

Conversation

@ruffsl
Copy link
Copy Markdown
Member

@ruffsl ruffsl commented Aug 11, 2020

Avoid duplicate colcon tests, and update/optimize CI config.
Context: #1284 (comment)

@SteveMacenski
Copy link
Copy Markdown
Member

What's the tl;dr on these changes? Any new or removed jobs for CI/nightlies?

@ruffsl
Copy link
Copy Markdown
Member Author

ruffsl commented Aug 11, 2020

The commit comments speak for themselves, but this doesn't add or remove jobs.

@ruffsl ruffsl merged commit 4c9b43f into ros-navigation:master Aug 11, 2020
@SteveMacenski
Copy link
Copy Markdown
Member

@ruffsl please squash merge your pull requests. It really messes with cherry picking and general maintenance if I can't isolate a commit to a PR.

@ruffsl
Copy link
Copy Markdown
Member Author

ruffsl commented Aug 11, 2020

I wanted to maintain the line-level blame history for the CI changes, as it makes it easier to revert individual commits. Although commits to the default branch config.yaml shouldn't need to be cherry picked, 4c9b43f seems to map to the PR. I think as long as we don't push directly to the default branch but go through GH PRs, there will always be hyperlinks between squash/merge commits and originating PRs.

@SteveMacenski
Copy link
Copy Markdown
Member

Well its really messed things up while trying to realign the 2 branches. I think its completely busted now and just needs to be redone. Please don’t do that in the future.

@SteveMacenski
Copy link
Copy Markdown
Member

SteveMacenski commented Aug 11, 2020

I have no idea how to fix this now, I did not expect there to be merge commits in the range and the output is really strange. Origin main I don’t think is repairable without hours of work. If you have 1 squashed commit that changes from master to main this would be easy to fix but I don’t see that anywhere in the history to pull from.

I thought I disabled merge commits without admin acknowledgement. I don’t know why that didn’t block this.

@ruffsl ruffsl deleted the ci-retest-2 branch August 12, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants