Skip to content

Removing deprecation warning#1075

Merged
SteveMacenski merged 1 commit intomasterfrom
SteveMacenski-patch-1
Aug 28, 2019
Merged

Removing deprecation warning#1075
SteveMacenski merged 1 commit intomasterfrom
SteveMacenski-patch-1

Conversation

@SteveMacenski
Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski commented Aug 28, 2019

Also sometimes I forget that GitHub's web code-editor isn't the worst thing I've seen 😆

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2019 •
edited
Loading

Codecov Report

Merging #1075 into master will increase coverage by 6.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
+ Coverage   28.12%   34.18%   +6.06%     
==========================================
  Files         238      238              
  Lines       10946    10945       -1     
  Branches     3534     4223     +689     
==========================================
+ Hits         3079     3742     +663     
+ Misses       5687     4593    -1094     
- Partials     2180     2610     +430
Flag Coverage Δ
#project 34.18% <ø> (+6.06%) ⬆️
Impacted Files Coverage Δ
src/navigation2/nav2_map_server/src/main.cpp 18.18% <0%> (-27.28%) ⬇️
...til/src/motion_model/differential_motion_model.cpp 67.56% <0%> (-5.41%) ⬇️
src/navigation2/nav2_navfn_planner/src/navfn.cpp 59.03% <0%> (-0.64%) ⬇️
...controller/dwb_core/include/dwb_core/publisher.hpp 0% <0%> (ø) ⬆️
...navigation2/nav2_bt_navigator/src/bt_navigator.cpp 0% <0%> (ø) ⬆️
...avigation2/nav2_costmap_2d/src/layered_costmap.cpp 50% <0%> (+1.56%) ⬆️
..._controller/dwb_critics/src/obstacle_footprint.cpp 1.88% <0%> (+1.88%) ⬆️
...roller/dwb_plugins/src/limited_accel_generator.cpp 3.44% <0%> (+3.44%) ⬆️
...dwb_controller/costmap_queue/src/costmap_queue.cpp 90.19% <0%> (+3.92%) ⬆️
..._dwb_controller/dwb_critics/src/prefer_forward.cpp 6.25% <0%> (+6.25%) ⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886e3e1...4da138a. Read the comment docs.

@SteveMacenski SteveMacenski merged commit c27d663 into master Aug 28, 2019
@ghost
Copy link
Copy Markdown

ghost commented Aug 28, 2019 •
edited by ghost
Loading

Didn't we just add this? Why are we removing it again?

Nevermind. Just saw the discussion on #1071

@SteveMacenski SteveMacenski deleted the SteveMacenski-patch-1 branch August 28, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkhansenbot mkhansenbot mkhansenbot approved these changes

+1 more reviewer

@bpwilcox bpwilcox bpwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SteveMacenski @mkhansenbot @bpwilcox